Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom subscriptions response. #961

Closed
wants to merge 9 commits into from

Conversation

maliming
Copy link

Description

This PR supports custom subscriptions response. Mainly to integrate Event-Bus in the ABP framework.

Issue reference

No

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@maliming
Copy link
Author

hi @halspang

Do you have time to review this PR?

@halspang
Copy link
Contributor

Thanks for opening this PR, but I'm not really sure what the point of this change is. Can you provide some more background on it?

@maliming
Copy link
Author

Thanks @halspang

The dapr/subscribe endpoint gets all endpoints that use TopicAttribute and returns JSON data.

This PR allows developers to change the subscription response, Such as hiding or dynamically adding some subscriptions.

This may not be commonly used, but it is convenient for some frameworks to integrate Dapr.

@halspang
Copy link
Contributor

@maliming - Thanks. However, it seems like WithTopic would do this, right? And any additional integrations would need to come from the runtime since this is a json that we return to the runtime, we need to adhere to its contract. Or am I missing something here?

@maliming
Copy link
Author

Yes, You're right.

We also have some concepts similar to publish/subscribe in our class library, and with the current design, we need to create a lot of controllers and methods for them and use TopicAttribute.

We want to create a controller and dynamically specify multiple topic/route.

@gdlcf88
Copy link

gdlcf88 commented Apr 21, 2023

Hey guys, any update? 🌹

@WhitWaldo
Copy link
Contributor

WhitWaldo commented Oct 11, 2024

Hello @maliming and thank you for your contribution!

I believe the new dynamic PubSub subscriptions capability introduced in 1.14 covers the idea behind your contribution - this will receive .NET SDK support with 1.15 via the PR at #1346.

If you disagree, please feel free to re-open and we can continue to discuss it.

@WhitWaldo WhitWaldo closed this Oct 11, 2024
@maliming
Copy link
Author

Thanks @WhitWaldo 👍 , I will check the #1346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants