-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom subscriptions response. #961
Conversation
hi @halspang Do you have time to review this PR? |
Thanks for opening this PR, but I'm not really sure what the point of this change is. Can you provide some more background on it? |
Thanks @halspang The This PR allows developers to change the subscription response, Such as hiding or dynamically adding some subscriptions. This may not be commonly used, but it is convenient for some frameworks to integrate Dapr. |
@maliming - Thanks. However, it seems like |
Yes, You're right. We also have some concepts similar to publish/subscribe in our class library, and with the current design, we need to create a lot of controllers and methods for them and use We want to create a controller and dynamically specify multiple topic/route. |
Hey guys, any update? 🌹 |
Hello @maliming and thank you for your contribution! I believe the new dynamic PubSub subscriptions capability introduced in 1.14 covers the idea behind your contribution - this will receive .NET SDK support with 1.15 via the PR at #1346. If you disagree, please feel free to re-open and we can continue to discuss it. |
Thanks @WhitWaldo 👍 , I will check the #1346 |
Description
This PR supports custom subscriptions response. Mainly to integrate Event-Bus in the ABP framework.
Issue reference
No
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: