Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Reformat index page #580

Merged
merged 13 commits into from
Jul 18, 2023
Merged

[docs] Reformat index page #580

merged 13 commits into from
Jul 18, 2023

Conversation

hhunter-ms
Copy link
Contributor

Description

Attempt to make the SDK index pages consistent. Reformatted Python index page to be consistent with .NET index page.

Issue reference

PR will close: dapr/docs#3600

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms requested review from a team as code owners July 5, 2023 22:12
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #580 (fda48f9) into master (18d93c6) will not change coverage.
The diff coverage is n/a.

❗ Current head fda48f9 differs from pull request most recent head 546ec56. Consider uploading reports for the commit 546ec56 to get more accurate results

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files          73       73           
  Lines        3531     3531           
=======================================
  Hits         3077     3077           
  Misses        454      454           

@hhunter-ms hhunter-ms changed the title [docs] Reformat index page [docs][WIP] Reformat index page Jul 5, 2023
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms changed the title [docs][WIP] Reformat index page [docs] Reformat index page Jul 11, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Workflow onto this page, with a link to the workflow example? Same as on the .NET page?

msfussell
msfussell previously approved these changes Jul 13, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
hhunter-ms and others added 6 commits July 17, 2023 11:49
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - super minor feedback. There is a paragraph I would remove under the Main SDK section.

hhunter-ms and others added 4 commits July 18, 2023 14:21
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@berndverst berndverst merged commit 152de30 into dapr:master Jul 18, 2023
12 checks passed
elena-kolevska pushed a commit to elena-kolevska/python-sdk that referenced this pull request Sep 4, 2023
* reformat index page

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* quick freshness pass on python client doc

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* edit based on bernd review

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* updates per bernd discussion

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* revert a bit

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* add note that workflow is in alpha

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* move workflow doc to extensions node

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* bernd review

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* update terminology, clean up docs org in toc

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* forgot one url ref

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

---------

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Co-authored-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python SDK] Reformat index page
3 participants