Changing error message in wf test to match runtime #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
berndverst
approved these changes
Jul 14, 2023
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
- Coverage 87.14% 86.85% -0.29%
==========================================
Files 73 73
Lines 3531 3531
==========================================
- Hits 3077 3067 -10
- Misses 454 464 +10 |
This was referenced Jul 14, 2023
elena-kolevska
pushed a commit
to elena-kolevska/python-sdk
that referenced
this pull request
Sep 4, 2023
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Signed-off-by: Elena Kolevska <elena@kolevska.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently the capitalization of an error message changed in dapr/dapr for workflow when GET was called on a non-existent ID. This PR changed the error message that we are comparing against in the workflow test to match the actual error message from dapr/dapr.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: