-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked javascript workflow examples to use a webserver #1039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion about env vars. thanks for contribution
could you also please quick to |
…use a webserver Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if checks pass
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
When someone from @dapr/approvers-workflows @dapr/maintainers-workflows has time, I cannot figure out why the initial run of the quickstart (using app.ts) is having a timeout exception, when others are not.
yields
|
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
I think I fixed the grpc "Cancelled on client" and timeout issue by moving the workflowWorker.stop call outside of the start loop into a SIGTERM handler, which seems like a better idea anyway. This looks like the same issue as dapr/js-sdk#595 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@holopin-bot @olitomlinson Thanks Oli! |
Congratulations @olitomlinson, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvbo5hg14920cmk0mngoylv This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Workflows are better expressed in the context of a webserver (this is how 99% of users will host and author workflows) therefore I've included working examples of how to do this, using native express and Dapr Server.
Issue reference
N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: