-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobs API Quickstarts #1056
Jobs API Quickstarts #1056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial look - haven't reviewed any of the unrelated changes to the jobs api.
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
…on 1.13 -> 1.14 Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
…o latest. docs: Updated read me files to use Java 17 as baseline Signed-off-by: amardeep2006 <amardeep2006@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
…on 1.13 -> 1.14 Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
…o latest. docs: Updated read me files to use Java 17 as baseline Signed-off-by: amardeep2006 <amardeep2006@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
* Update tutorials pub-sub csharp-subscriber image to dotnet 8.0 Signed-off-by: Anton Troshin <anton@diagrid.io> * Update Dockerfile Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Anton Troshin <anton@diagrid.io> Signed-off-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernandorsl@gmail.com>
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Signed-off-by: Fernando Rocha <fernandorsl@gmail.com>
1. Open a terminal and run the `job-service` app: | ||
|
||
```bash | ||
dapr run --app-id job-service --app-port 6200 --dapr-http-port 6280 --dapr-grpc-port 6281 --app-protocol grpc -- go run . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need these settings ?
--dapr-http-port 6280 --dapr-grpc-port 6281 --app-protocol grpc
And if only grpc, then why provide the HTTP one?
Can you have this instead?
dapr run --app-id job-service --app-port 6200 -- go run .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the grpc protocol is handling the job callback when it is triggered. what we don't need is the http port, really. I'll remove it.
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Signed-off-by: Fernando Rocha <fernando@diagrid.io>
Description
Including SDK and HTTP quickstart examples in Go for the Jobs API.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1026
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: