Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch port with description #893

Closed
wants to merge 1 commit into from
Closed

Conversation

iporsut
Copy link

@iporsut iporsut commented Jul 30, 2023

Description

Port that set in http listener is not the same as description.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Weerasak Chongnguluam <singpor@gmail.com>
@msfussell msfussell added this to the 1.11 milestone Jul 31, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could have changed the doc, but the code change is also fine since this is in one place

@iporsut
Copy link
Author

iporsut commented Aug 2, 2023

I think we should fix at the documentation because port was changed in this commit to make it uniq ea182d5

@iporsut iporsut closed this Aug 2, 2023
@iporsut iporsut deleted the patch-1 branch August 2, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants