Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback C.simplify ir_version error to C.simplify_path #336

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

triple-Mu
Copy link
Contributor

Fix onnxsim about simplifying larger than 2G onnx model.
It will raise an error in C.simplify: onnx.onnx_cpp2py_export.checker.ValidationError: The model does not have an ir_version set properly.
And it cannot be solved by downgrading the version of onnx/onnxsim/protobuf.
But we can catch this exception and treat it as equivalent to a value error about exceeding 2GB.
Then C.simplify_path works well now.

@triple-Mu triple-Mu changed the title fallback C.simplify ir_version error to simplify_path fallback C.simplify ir_version error to C.simplify_path Jul 8, 2024
@daquexian daquexian merged commit 1379b14 into daquexian:master Jul 8, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants