-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alt parsing #29
Alt parsing #29
Conversation
Hmm interesting this was originally how I did this. You have cleaned up the flow alot thanks! Let me have a look, at this. |
The Did you try with any mods that had sub-components? @podcherklife ? |
If you could avoid |
If user input is incorrect we should just |
There is a few clippy errors too you can fix them with the following: cargo clippy --fix --allow-dirty --allow-staged |
Frankly, I am not exactly familiar with the terminology in IE modding. I might be misunderstanding something though. But again, I've tested this on a log with ~500 entries and the output log is exactly the same as the input log. |
We don't know that however. Its the mod authors who handle input and validation. If there was some kind of AWAITING_INPUT marker from weidu, then we could do something like that but alas, there is no such thing(and I did not manage to build weidu locally to try to add it =) ).
Now that I think of it it might actually be possible to programmatically figure out if weidu process is waiting for input(at least on linux) by using |
Yes I'd like to avoid strace everything. Agreed it seems like adding back in all the choices made it a bit more unstable. I don't really wish to add a GUI, my vision would be so ffi out to weidu rather than all this command line text parsing. Some thing like this: https://github.com/zshipko/ocaml-rs. |
I was effectively doing this. |
@podcherklife thank you so much for your pr! |
So, I've got a weidu.log with several hundreds of entries. This PR is the result my attempts to use that log to reinstall EET. It works for me(requires some manual input for mods that use READLN commands though), but I am pretty sure I might have broken some use cases.
Points of interest:
--yes --ask-only {component}
to--force-install
For whatever reason
--yes --ask-only
was not working with dlc-merger for me.With
--force-install
though weidu produces the exact same weidu.log as the one that was used as an input.--force-install
makes it so that inputting[Y]
is no longer required, but then there is an inherent problem with READLN commands, and I don't think there can be a general solution for that. This implementation seems to mostly work(i.e. works for me) but does not handle the case when user input is incorrect and weidu rejects it.