Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SenorKarlos PR Port] Adding an option to hide the Pokemon stats #90

Open
wants to merge 10 commits into
base: MIX_MEWTWO
Choose a base branch
from

Conversation

darkelement1987
Copy link
Owner

@darkelement1987 darkelement1987 commented Apr 13, 2018

Description

When encounters are activated, a malicious user can ask for all the statistics, even when the statistics are disabled by configuration in the JavaScript code.

With this change you can be able to hide the stats, so when the frontend asks for the Pokemon, it will return an array of Pokemon with all the statistics removed.

This doesn't affect at all to webhooks or database storage

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@darkelement1987 darkelement1987 added the help wanted Extra attention is needed label Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant