Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HideButton not hiding the whole button #1

Open
compojoom opened this issue Apr 18, 2011 · 3 comments
Open

HideButton not hiding the whole button #1

compojoom opened this issue Apr 18, 2011 · 3 comments

Comments

@compojoom
Copy link

Using the hideButton function doesn't hide the button, but the text in the button.

I think that the hiddenButton class should be added to the label and not on the input itself.

@compojoom
Copy link
Author

I've changed the hideButton function to this:

hideButton: function(title) {
if(this.buttons[title]) this.buttons[title].getParent().addClass('hiddenButton');
return this.buttons[title];
}
and now it appears that the buttons is properly hidden, but I'm not 100% sure that it doesn't brake something else. :)

@compojoom compojoom reopened this Apr 18, 2011
@SitePenDavidWalsh
Copy link
Contributor

Weird...can you add a test case or link to an example? Possibly at jsfiddle?

@compojoom
Copy link
Author

There you go:
http://jsfiddle.net/compojoom/pu2aN/1/

Hope you don't mind that I've copied your css stylesheet and have added the js resource directly from your page.

Cheers,
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants