From 739f12cfe6ca14adb7ecf19b4e67e421ab3d105f Mon Sep 17 00:00:00 2001 From: Daco Harkes Date: Thu, 27 Jun 2024 20:42:52 +0200 Subject: [PATCH] [native_assets_cli] Fix toString of objects used in test names (#1241) --- .../lib/src/model/native_code_asset.dart | 12 ++++++++++++ pkgs/native_assets_cli/test/api/asset_test.dart | 8 ++++++++ 2 files changed, 20 insertions(+) diff --git a/pkgs/native_assets_cli/lib/src/model/native_code_asset.dart b/pkgs/native_assets_cli/lib/src/model/native_code_asset.dart index 9863303ba..962a137fe 100644 --- a/pkgs/native_assets_cli/lib/src/model/native_code_asset.dart +++ b/pkgs/native_assets_cli/lib/src/model/native_code_asset.dart @@ -93,6 +93,9 @@ final class DynamicLoadingBundledImpl DynamicLoadingImpl._uriKey: file!.toFilePath(), } }; + + @override + String toString() => _typeValue; } final class DynamicLoadingSystemImpl @@ -130,6 +133,9 @@ final class DynamicLoadingSystemImpl } return uri == other.uri; } + + @override + String toString() => _typeValue; } final class LookupInProcessImpl implements DynamicLoadingImpl, LookupInProcess { @@ -154,6 +160,9 @@ final class LookupInProcessImpl implements DynamicLoadingImpl, LookupInProcess { DynamicLoadingImpl._pathTypeKeyV1_0_0: _typeValueV1_0_0, } }; + + @override + String toString() => _typeValue; } final class LookupInExecutableImpl @@ -199,6 +208,9 @@ final class StaticLinkingImpl implements LinkModeImpl, StaticLinking { Map toJsonV1_0_0(Uri? file) => { NativeCodeAssetImpl._linkModeKey: _typeValue, }; + + @override + String toString() => _typeValue; } final class NativeCodeAssetImpl implements NativeCodeAsset, AssetImpl { diff --git a/pkgs/native_assets_cli/test/api/asset_test.dart b/pkgs/native_assets_cli/test/api/asset_test.dart index c01772a9d..f256dcfb3 100644 --- a/pkgs/native_assets_cli/test/api/asset_test.dart +++ b/pkgs/native_assets_cli/test/api/asset_test.dart @@ -62,6 +62,14 @@ void main() { assets.toString(); }); + test('toString', () { + StaticLinking().toString(); + DynamicLoadingBundled().toString(); + DynamicLoadingSystem(Uri.file('foo.so')).toString(); + LookupInProcess().toString(); + LookupInExecutable().toString(); + }); + test('Errors', () { expect( () => NativeCodeAsset(