-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use check:jni for tests and fix warnings #1077
Conversation
PR HealthLicense Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
2 similar comments
PR HealthLicense Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthLicense Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
pkgs/jni/test/type_test.dart
Outdated
@@ -205,7 +205,8 @@ final class $FType extends JObjType<F> { | |||
void main() { | |||
if (!Platform.isAndroid) { | |||
checkDylibIsUpToDate(); | |||
Jni.spawnIfNotExists(dylibDir: "build/jni_libs", jvmOptions: ["-Xmx128m"]); | |||
Jni.spawnIfNotExists( | |||
dylibDir: "build/jni_libs", jvmOptions: ["-Xmx128m", "-Xcheck:jni"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make a helper method somewhere to ensure we have the same options everywhere?
Closes #1067.