Stop resolving Uris encoded in the build protocol #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a `hook/{build,link}.dart` no longer resolve uris encoded in the
`config.json`. It still validates that the uris that are encoded exist
when it decodes the json.
The creator of `config.json` has to ensure that the uris it encodes in
that config are existing file urls that the `hook/{build,link}.dart`
scripts can open as-is (i.e. without resolving against any base uri).
In many cases that means that an invoker should encode absolute uris in
there - or if it encodes relative uris - guarantees that they are
relative to the working directory the `hook/{build,link}.dart` is
invoked.
Issue #1605
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
dcharkes
approved these changes
Sep 26, 2024
|
Thanks, @dcharkes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a
hook/{build,link}.dartno longer resolve uris encoded in theconfig.json. It still validates that the uris that are encoded exist when it decodes the json.The creator of
config.jsonhas to ensure that the uris it encodes in that config are existing file urls that thehook/{build,link}.dartscripts can open as-is (i.e. without resolving against any base uri).In many cases that means that an invoker should encode absolute uris in there - or if it encodes relative uris - guarantees that they are relative to the working directory the
hook/{build,link}.dartis invoked.Issue #1605