Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop resolving Uris encoded in the build protocol #1607

Merged
merged 4 commits into from
Sep 26, 2024

Commits on Sep 26, 2024

  1. Stop resolving Uris encoded in the build protocol

    This makes a `hook/{build,link}.dart` no longer resolve uris encoded in the
    `config.json`. It still validates that the uris that are encoded exist
    when it decodes the json.
    
    The creator of `config.json` has to ensure that the uris it encodes in
    that config are existing file urls that the `hook/{build,link}.dart`
    scripts can open as-is (i.e. without resolving against any base uri).
    
    In many cases that means that an invoker should encode absolute uris in
    there - or if it encodes relative uris - guarantees that they are
    relative to the working directory the `hook/{build,link}.dart` is
    invoked.
    
    Issue #1605
    mkustermann committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7647d95 View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    mkustermann committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9c61e22 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b9e45d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bd8f830 View commit details
    Browse the repository at this point in the history