Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubspec_parse: Added support for executables field in pubspec.yaml #1952

Merged
merged 10 commits into from
Jan 7, 2025

Conversation

Dhruv-Maradiya
Copy link
Contributor

Description

Fixes #1806 by adding support for the executables field in the pubspec.yaml file.

Changes

  • Added the executables field to the Pubspec class in lib/src/pubspec.dart.
  • Updated generated code in lib/src/pubspec.g.dart to include support for executables.
  • Added tests to validate parsing and handling of the executables field.
  • Updated CHANGELOG.md to document the changes.

Checklist

  • I’ve reviewed the contributor guide and followed the relevant guidelines.
  • Added tests to ensure the new feature works as intended.

Copy link

github-actions bot commented Dec 28, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
pubspec_parse Non-Breaking 1.4.0 1.5.0 1.4.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/pubspec_parse/lib/src/pubspec.dart 💔 98 % ⬇️ 2 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

pkgs/pubspec_parse/CHANGELOG.md Outdated Show resolved Hide resolved
pkgs/pubspec_parse/lib/src/pubspec.dart Outdated Show resolved Hide resolved
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tweak the changelog.

Dhruv-Maradiya and others added 2 commits January 3, 2025 12:24
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
@Dhruv-Maradiya Dhruv-Maradiya requested a review from kevmoo January 3, 2025 07:04
@Dhruv-Maradiya
Copy link
Contributor Author

Hi @kevmoo,

Thank you for your feedback and suggestions earlier! 🙌

I've committed the changelog and resolved the conversations for the other comments.

Please let me know if there's anything else you'd like me to address. I appreciate your time and guidance! 😊

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good w/ the indicated parsing change (and version bumps).

pkgs/pubspec_parse/lib/src/pubspec.dart Outdated Show resolved Hide resolved
pkgs/pubspec_parse/CHANGELOG.md Outdated Show resolved Hide resolved
@devoncarew
Copy link
Member

Re:

error: pubspec version (1.5.0-wip) and changelog (1.5.0) don't agree

I think we'll need to update the pubspec.yaml version as well.

@Dhruv-Maradiya
Copy link
Contributor Author

Hi, @devoncarew

Apologies for missing the version update in pubspec.yaml. I'll make sure to double-check next time. Thanks for pointing it out!

Copy link

github-actions bot commented Jan 7, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:pubspec_parse 1.5.0 ready to publish pubspec_parse-v1.5.0
package:file_testing 3.1.0-wip WIP (no publish necessary)
package:boolean_selector 2.1.2 already published at pub.dev
package:browser_launcher 1.1.3 already published at pub.dev
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:cli_util 0.4.2 already published at pub.dev
package:clock 1.1.2 already published at pub.dev
package:code_builder 4.10.1 already published at pub.dev
package:coverage 1.11.1 already published at pub.dev
package:csslib 1.0.2 already published at pub.dev
package:extension_discovery 2.1.0 already published at pub.dev
package:file 7.0.2-wip WIP (no publish necessary)
package:bazel_worker 1.1.3-wip WIP (no publish necessary)
package:graphs 2.3.3-wip WIP (no publish necessary)
package:html 0.15.5 already published at pub.dev
package:io 1.0.5 already published at pub.dev
package:json_rpc_2 3.0.3 already published at pub.dev
package:mime 2.0.0 already published at pub.dev
package:oauth2 2.0.4-wip WIP (no publish necessary)
package:package_config 2.1.1 already published at pub.dev
package:pool 1.5.2-wip WIP (no publish necessary)
package:pub_semver 2.1.5 already published at pub.dev
package:benchmark_harness 2.3.1 already published at pub.dev
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:yaml_edit 2.2.2 already published at pub.dev
package:source_span 1.10.1 already published at pub.dev
package:sse 4.1.7 already published at pub.dev
package:stack_trace 1.12.1 already published at pub.dev
package:stream_channel 2.1.4 already published at pub.dev
package:stream_transform 2.1.2-wip WIP (no publish necessary)
package:string_scanner 1.4.1 already published at pub.dev
package:term_glyph 1.2.3-wip WIP (no publish necessary)
package:test_reflective_loader 0.2.3 already published at pub.dev
package:timing 1.0.2 already published at pub.dev
package:unified_analytics 7.0.1 already published at pub.dev
package:watcher 1.1.1 already published at pub.dev
package:yaml 3.1.3 already published at pub.dev
package:source_maps 0.10.14-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevmoo kevmoo merged commit 070355e into dart-lang:main Jan 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the "executables" field
3 participants