Feat: disable battery optimization #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
changed the title
Syn-McJ
requested changes
Oct 16, 2023
There was a problem hiding this comment.
@HashEngineering some changes are needed to avoid passing WalletApplication to the report dialog since we want to reduce our reliability on this god-class.
| @@ -1114,4 +1117,15 @@ public void checkSendingConditions( | |||
| crowdNodeConfig | |||
| ); | |||
| } | |||
|
|
|||
| public final HashCode apkHash() throws IOException { | |||
There was a problem hiding this comment.
This should be moved to PackageInfoProvider, and then getPackageCodePath() can be accessed from the @ApplicationContext private val context: Context
There was a problem hiding this comment.
These changes were made.
| final PackageInfoProvider packageInfoProvider, | ||
| final Configuration configuration, | ||
| final Wallet wallet, | ||
| final WalletApplication application |
There was a problem hiding this comment.
We shouldn't provide the entire WalletApplication to this dialog - I made some changes recently so that PackageInfoProvider has everything needed here.
There was a problem hiding this comment.
These changes were made.
…hevo/dash-wallet into feature-battery-optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Report Changes:
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: