Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coinjoin): Entry Point #1216

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 7, 2023

The entry point for CoinJoin settings.

Issue being fixed or feature implemented

  • Menu item
  • Info fragment

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Oct 7, 2023
Comment on lines +30 to +35
<!-- <action-->
<!-- android:id="@+id/info_to_level"-->
<!-- app:destination="@id/coinjoinLevelFragment"-->
<!-- app:enterAnim="@anim/slide_in_right"-->
<!-- app:exitAnim="@anim/activity_stay"-->
<!-- app:popExitAnim="@anim/slide_out_left" />-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this action? If not now, later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll use it later. It's annoying to look for the correct animations so I left them here.

@Syn-McJ Syn-McJ changed the base branch from merge-master-into-dashpay to dashpay October 10, 2023 02:19
@HashEngineering HashEngineering self-requested a review October 10, 2023 13:22
@HashEngineering HashEngineering merged commit 7f1ca22 into dashpay Oct 10, 2023
2 checks passed
@Syn-McJ Syn-McJ deleted the dashpay-coinjoin-entrypoint branch October 10, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants