Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashpay): add coinjoin error handling to enter amount screen #1247

Merged
merged 9 commits into from
Jan 23, 2024
Merged

feat(dashpay): add coinjoin error handling to enter amount screen #1247

merged 9 commits into from
Jan 23, 2024

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Jan 12, 2024 •
edited
Loading

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering self-assigned this Jan 12, 2024
@HashEngineering HashEngineering changed the base branch from master to dashpay January 22, 2024 00:27
@HashEngineering HashEngineering marked this pull request as ready for review January 22, 2024 00:33
Syn-McJ
Syn-McJ approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small improvement suggestion.

wallet/src/de/schildbach/wallet/ui/send/SendCoinsFragment.kt Outdated Show resolved Hide resolved
Syn-McJ
Syn-McJ approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering merged commit eac2283 into dashpay Jan 23, 2024
2 checks passed
@HashEngineering HashEngineering deleted the dashpay-feature-coinjoin-error-handling branch January 23, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @Syn-McJ