-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update tx list with observeTransactions #1331
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, updating rows is working in my testing.
One potential optimization could be made: if we move grouping by date into the ViewModel from the fragment:
val groupedByDate = transactionViews.groupBy {
Instant.ofEpochMilli(it.time).atZone(ZoneId.systemDefault()).toLocalDate()
}
then we might be able keep a grouped map of transactions, something like this:
private val _transactions = MutableLiveData<Map<LocalDate, List<TransactionRowView>>>()
Then, finding the proper row to change is easier since you only need to get the group based on the transaction date and search within it.
This probably isn't necessary if there is already enough performance benefits achieved.
…bugfix-observe-tx
…bugfix-observe-tx
…ges for the past hour of tx's
* feat: add ContactSupportDialogFragment and ViewModel * feat: use ContactSupportDialogFragment * fix: improve wallet dump * fix: sort logFiles by most recent date first, then limit to 20MB * fix: disable auto logout when creating report * chore: remove ReportIssueDialogBuilder * fix: update wifi warning for mixing fees (#1334)
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: