Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that we can dask.compute multiple collections simultaneously #312

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

douglasdavis
Copy link
Collaborator

Fix #299

@lgray your reproducer in #299 runs for me with this PR!

I'm surprised at how small of a code change this is w.r.t. how gnarly of a problem it seemed when I first started digging into upstream dask code 😛

@lgray
Copy link
Collaborator

lgray commented Jul 6, 2023

make the reproducer a test?

@lgray
Copy link
Collaborator

lgray commented Jul 6, 2023

If we can merge this and cut a new release there's a few things I need for some tests on a batch queue.

@codecov-commenter
Copy link

Codecov Report

Merging #312 (e153158) into main (c00b6d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e153158 differs from pull request most recent head ee2c45c. Consider uploading reports for the commit ee2c45c to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files          21       21           
  Lines        2562     2564    +2     
=======================================
+ Hits         2365     2367    +2     
  Misses        197      197           
Impacted Files Coverage Δ
src/dask_awkward/lib/optimize.py 93.99% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglasdavis
Copy link
Collaborator Author

douglasdavis commented Jul 6, 2023

make the reproducer a test?

for some reason uproot.dask http (in pytest) takes quite a while when I try to run it locally, I had started putting together something using existing fixtures. It mimics the reproducer and then some. when CI is green I'll merge and cut a release

@douglasdavis douglasdavis enabled auto-merge (squash) July 6, 2023 22:01
@douglasdavis douglasdavis merged commit c9fc4d4 into dask-contrib:main Jul 6, 2023
22 checks passed
@douglasdavis douglasdavis deleted the multiple-computes branch July 6, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run compute simultaneously with multiple different input layers
3 participants