fix: make unproject_layout do nothing (just return original layout)
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasdavis
changed the title
unproject_layout do nothing (just return original layout)unproject_layout do nothing (just return original layout)
|
ran tests on coffea and it looks like we're good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts our form hydration feature originally added in #184. It appears to have triggered #313 and #314. We need more testing of the feature before it's ready.
This PR is an alternative to #317. In that PR we not only revert unproject_layout's action, but we also introduce more touching in the column optimization to make up for what unproject_layout was trying to accomplish. Unfortunately using
shape_touchedfrom the typetracer report causing over-touching of data.cc @lgray