Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better error message when no collections passed to map_partitions. #325

Merged

Conversation

douglasdavis
Copy link
Collaborator

based on convsersation in IRIS-HEP slack; it's possible to call a dask-awkward version of an awkward function but pass in concrete Arrays. Before this PR we hit a confusing IndexError when no
collections were found. This will raise a less confusing error

@codecov-commenter
Copy link

Codecov Report

Merging #325 (f38c2e6) into main (cf2fc37) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   94.68%   94.69%   +0.01%     
==========================================
  Files          20       20              
  Lines        2447     2452       +5     
==========================================
+ Hits         2317     2322       +5     
  Misses        130      130              
Impacted Files Coverage Δ
src/dask_awkward/lib/core.py 91.92% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglasdavis douglasdavis merged commit d10fb42 into dask-contrib:main Jul 20, 2023
22 checks passed
@douglasdavis douglasdavis deleted the better-map-partitions-error branch July 20, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants