fix: have unproject_layout modify the input layout again
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ref #313 |
douglasdavis
force-pushed
the
unproject-layout-dev
branch
from
7b47972
to
75d65fd
Compare
douglasdavis
changed the title
unproject_layout modify the input layout again
|
any blockers on getting this merged + release? It's only fixed tests that were failing on my side and no other side effects. Any remaining work on this axis? also pinging @agoose77 |
|
In theory, we're back where we were supposed to be in July: this PR will fix the column optimisation, but we expect it to have some problems where nested contents have lengths that need to be determined. I think that's probably a better error to encounter, and we anticipate it. I'm working towards that fix; right now, I'm addressing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.