-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use ak.typetracer.XX
high-level functions
#351
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@douglasdavis I've removed part of an existing test that invokes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agoose77 that test was meant to address an issue with calling from_awkward
on an empty array (that test was written with this PR: #330); ak.Array(some_form.length_zero_array(highlevel=False))
was being used just to create an empty awkward array (so not using a typetracer, but an empty high level array). was the test failing for after the changes in this PR?
@douglasdavis gah, I'm doing too much refactoring work in parallel — I changed the function of this test in a previous commit. Good spot, let me recover the original intention. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 94.80% 94.86% +0.05%
==========================================
Files 20 20
Lines 2485 2475 -10
==========================================
- Hits 2356 2348 -8
+ Misses 129 127 -2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@agoose77 sounds good- if you have nothing else to add this looks good to me! |
Depends upon scikit-hep/awkward#2671