Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use ak.typetracer.XX high-level functions #351

Merged
merged 10 commits into from
Sep 6, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77
Copy link
Collaborator Author

agoose77 commented Sep 5, 2023

@douglasdavis I've removed part of an existing test that invokes dak.from_awkward upon an Awkward Array backed by a typetracer. I think this should be an error; typetracers should be an internal detail of dask-awkward. Do you agree with this? If so, I will keep the change and update the PR to add a test for the array backend in from_awkward.

Copy link
Collaborator

@douglasdavis douglasdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agoose77 that test was meant to address an issue with calling from_awkward on an empty array (that test was written with this PR: #330); ak.Array(some_form.length_zero_array(highlevel=False)) was being used just to create an empty awkward array (so not using a typetracer, but an empty high level array). was the test failing for after the changes in this PR?

@agoose77
Copy link
Collaborator Author

agoose77 commented Sep 5, 2023

@douglasdavis gah, I'm doing too much refactoring work in parallel — I changed the function of this test in a previous commit. Good spot, let me recover the original intention.

@codecov-commenter
Copy link

Codecov Report

Merging #351 (8670e28) into main (21fc848) will increase coverage by 0.05%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   94.80%   94.86%   +0.05%     
==========================================
  Files          20       20              
  Lines        2485     2475      -10     
==========================================
- Hits         2356     2348       -8     
+ Misses        129      127       -2     
Files Changed Coverage Δ
src/dask_awkward/__init__.py 100.00% <ø> (ø)
src/dask_awkward/lib/__init__.py 100.00% <ø> (ø)
src/dask_awkward/lib/io/io.py 100.00% <ø> (ø)
src/dask_awkward/layers/layers.py 94.79% <100.00%> (-0.21%) ⬇️
src/dask_awkward/lib/core.py 91.97% <100.00%> (-0.03%) ⬇️
src/dask_awkward/lib/io/parquet.py 93.29% <100.00%> (+1.21%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglasdavis
Copy link
Collaborator

@agoose77 sounds good- if you have nothing else to add this looks good to me!

@agoose77 agoose77 merged commit 6716eea into main Sep 6, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants