fix: use duck-typing check in place of isinstance(..., np.ndarray)
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 94.02% 94.03%
=======================================
Files 23 23
Lines 3063 3066 +3
=======================================
+ Hits 2880 2883 +3
Misses 183 183
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
douglasdavis
commented
Nov 2, 2023
| def _finalize_array(results: Sequence[Any]) -> Any: | ||
| # special cases for length 1 results | ||
| if len(results) == 1: | ||
| if isinstance(results[0], (int, ak.Array, np.ndarray)): | ||
| np_like = _is_numpy_or_cupy_like(results[0]) | ||
| if isinstance(results[0], (int, ak.Array)) or np_like: # type: ignore[unreachable] |
There was a problem hiding this comment.
I have no idea why mypy is complaining that the second half of this or is unreachable. It's absolutely reachable! results[0] is an Any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #401