Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad dtype definition for dak.num(..., axis=0) metadata #417

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

douglasdavis
Copy link
Collaborator

np.int64 is not a proper dtype, np.dtype("int64") is.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa07194) 93.94% compared to head (a1b55a2) 93.94%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          23       23           
  Lines        3123     3123           
=======================================
  Hits         2934     2934           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ikrommyd
Copy link
Contributor

It works for me but I'm getting a warning

In [9]: dak.num(events, axis=0).compute()
/Users/iason/fun/coffea_dev/dask-awkward/src/dask_awkward/lib/optimize.py:150: UserWarning: The necessary columns optimization failed; exception raised:

<class 'AssertionError'> with message bug in Awkward Array: attempt to convert TypeTracerArray into a concrete array.

Please see the FAQ section of the docs for more information:
https://dask-awkward.readthedocs.io/en/stable/more/faq.html

Is this fine?

@douglasdavis
Copy link
Collaborator Author

Nope! fixed the warning :)

@douglasdavis douglasdavis merged commit 40e6b35 into dask-contrib:main Nov 15, 2023
22 of 23 checks passed
@douglasdavis douglasdavis deleted the fix-ak-num-axis0-dtype branch November 15, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants