Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interface for returning reports from function classes passed to from_map #433

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

douglasdavis
Copy link
Collaborator

@douglasdavis douglasdavis commented Dec 7, 2023

This supersedes #415

High level overview: dask-awkward's from_map function takes a callable as the first argument (func). If that callable has a return_report property that returns True, then from_map will return two collections. The first will be the Array collection of interest (computes to be the intended data array) and the second will be another Array collection that computes to some user defined thing implemented for the specific func that gets passed into from_map.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2ce95fa) 92.96% compared to head (d64f8a5) 93.06%.

Files Patch % Lines
src/dask_awkward/lib/io/parquet.py 88.88% 3 Missing ⚠️
src/dask_awkward/lib/io/columnar.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   92.96%   93.06%   +0.10%     
==========================================
  Files          23       23              
  Lines        3197     3245      +48     
==========================================
+ Hits         2972     3020      +48     
  Misses        225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglasdavis douglasdavis changed the title feat: add interface for returning reports from input layers. feat: add interface for returning reports from function classes passed to from_map Dec 8, 2023
@douglasdavis douglasdavis merged commit 910ca6b into dask-contrib:main Dec 11, 2023
24 checks passed
@douglasdavis douglasdavis deleted the failure-report-2 branch December 11, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants