Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more obvious names for report products #478

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

lgray
Copy link
Collaborator

@lgray lgray commented Mar 1, 2024

Call the report output report and the from-uproot part from-uproot (or whatever input file format it happens to be) but with a different token key.

@lgray lgray requested a review from martindurant March 1, 2024 18:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (8cb8994) to head (67ab7d7).
Report is 20 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   93.06%   93.10%   +0.03%     
==========================================
  Files          23       23              
  Lines        3290     3305      +15     
==========================================
+ Hits         3062     3077      +15     
  Misses        228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgray lgray merged commit 5f7a137 into dask-contrib:main Mar 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants