Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly remove vacuum from this library #16

Closed
MrPowers opened this issue May 27, 2023 · 2 comments
Closed

Possibly remove vacuum from this library #16

MrPowers opened this issue May 27, 2023 · 2 comments

Comments

@MrPowers
Copy link

delta-rs already has DeltaTable.vacuum(). We should consider removing vacuum from this library if it's not needed.
@fjetter
Copy link
Contributor

fjetter commented Jun 23, 2023

I agree that we should not double functionality.

There also appears to be some misunderstanding. This library implements another delete call on the files. IIUC DeltaTable.vacuum is already deleting (i.e. it removes the files from store and not just from the deltalake log) all files and we don't need a dask concurrency layer to do this. @MrPowers can you confirm this?

@fjetter fjetter mentioned this issue Jun 23, 2023
Closed
This was referenced Jul 12, 2023
Closed
Merged
@fjetter
Copy link
Contributor

fjetter commented Jul 14, 2023

Closed by #46

@fjetter fjetter closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrPowers @fjetter