Drop python 3.8 #35
Merged
Drop python 3.8 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #35 +/- ##
===========================================
- Coverage 92.85% 73.28% -19.57%
===========================================
Files 2 4 +2
Lines 112 307 +195
===========================================
+ Hits 104 225 +121
- Misses 8 82 +74 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
j-bennet
reviewed
Jul 10, 2023
jacobtomlinson
approved these changes
Jul 10, 2023
jrbourbeau
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Thanks @fjetter -- there's a linting issue, but otherwise this LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more recent dask versions no longer support 3.8 and I don't think it's worth keeping it around for this lib