Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme improvements #40

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Conversation

j-bennet
Copy link
Collaborator

Update readme.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #40 (22c7c61) into main (9adc684) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files           6        6           
  Lines         340      340           
=======================================
  Hits          259      259           
  Misses         81       81           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement.

One thing I notice when reading his through is that it doesn't mention the phrase "Delta Lake" if at all, and I expect many people will be searching for things like "Dask Delta Lake". Maybe we should drop that phrase through some more?

@jrbourbeau jrbourbeau mentioned this pull request Jul 11, 2023
@j-bennet
Copy link
Collaborator Author

One thing I notice when reading his through is that it doesn't mention the phrase "Delta Lake" if at all, and I expect many people will be searching for things like "Dask Delta Lake". Maybe we should drop that phrase through some more?

I agree, I was wondering why we named the package dask-deltatable and not dask-deltalake in the first place. To me dask-deltalake would be more telling, as well. I'll see if I can insert more of those keywords.

@j-bennet
Copy link
Collaborator Author

@jrbourbeau do you have the chance to review / merge?

@fjetter
Copy link
Contributor

fjetter commented Jul 12, 2023

I agree, I was wondering why we named the package dask-deltatable and not dask-deltalake in the first place. To me dask-deltalake would be more telling, as well. I'll see if I can insert more of those keywords.

That name is already taken on PyPI. I reached out to the maintainer to see if we can have it. For now, we should stick with what we have.

@fjetter fjetter merged commit daa8dc9 into dask-contrib:main Jul 12, 2023
10 checks passed
@j-bennet j-bennet deleted the j-bennet/readme-update branch July 12, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants