fix(DMVP-5080): have ability to output dns zone delegation NS records

README.md

@@ -2,6 +2,11 @@
 Allows to create aws route53 zone and record with simple manner,
 supports alb/loadbalancer and cdn/cloudfront cases
 
+# for enabling git pre-commit/commit-msg hooks run this(other repos will also have it set as it set globally)
+```sh
+git config --global core.hooksPath ./githooks
+```
+
 # simple example with alb
 ```hcl
 module "dns" {
@@ -55,5 +60,6 @@ No resources.
 
 | Name | Description |
 |------|-------------|
+| <a name="output_ns_delegation_set"></a> [ns\_delegation\_set](#output\_ns\_delegation\_set) | The NS records list for zone to use as delegation set |
 | <a name="output_zone_id"></a> [zone\_id](#output\_zone\_id) | zone id |
 <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

modules/route53/README.md

@@ -99,7 +99,7 @@ No requirements.
 
 | Name | Source | Version |
 |------|--------|---------|
-| <a name="module_zone"></a> [zone](#module\_zone) | ./zone | n/a |
+| <a name="module_zone"></a> [zone](#module\_zone) | ../zone | n/a |
 
 ## Resources
 
@@ -123,5 +123,6 @@ No requirements.
 | Name | Description |
 |------|-------------|
 | <a name="output_arn"></a> [arn](#output\_arn) | Returns zone arn. |
+| <a name="output_name_servers"></a> [name\_servers](#output\_name\_servers) | Returns zone name servers list. |
 | <a name="output_zone_id"></a> [zone\_id](#output\_zone\_id) | Returns zone id. |
 <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

modules/route53/main.tf

@@ -1,5 +1,5 @@
 module "zone" {
-  source = "./zone"
+  source = "../zone"
   count  = var.create_zone ? 1 : 0
 
   name = var.zone

modules/route53/output.tf

@@ -6,3 +6,8 @@ output "arn" {
   value       = var.create_zone ? module.zone[0].arn : data.aws_route53_zone.main[0].arn
   description = "Returns zone arn."
 }
+
+output "name_servers" {
+  value       = var.create_zone ? module.zone[0].name_servers : data.aws_route53_zone.main[0].name_servers
+  description = "Returns zone name servers list."
+}

modules/route53/zone/README.md → modules/zone/README.md

@@ -32,5 +32,6 @@ No modules.
 | Name | Description |
 |------|-------------|
 | <a name="output_arn"></a> [arn](#output\_arn) | Return created zone arn. |
+| <a name="output_name_servers"></a> [name\_servers](#output\_name\_servers) | Return created zone name\_servers. |
 | <a name="output_zone_id"></a> [zone\_id](#output\_zone\_id) | Return created zone id. |
 <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

modules/zone/main.tf

@@ -0,0 +1,3 @@
+resource "aws_route53_zone" "main" {
+  name = var.name
+}

modules/route53/zone/main.tf → modules/zone/outputs.tf

@@ -1,20 +1,14 @@
-# variables
-variable "name" {
-  type        = string
-  description = "Route53 Zone name"
-}
-
-# outputs
 output "zone_id" {
   value       = aws_route53_zone.main.zone_id
   description = "Return created zone id."
 }
+
 output "arn" {
   value       = aws_route53_zone.main.arn
   description = "Return created zone arn."
 }
 
-# resources
-resource "aws_route53_zone" "main" {
-  name = var.name
+output "name_servers" {
+  value       = aws_route53_zone.main.name_servers
+  description = "Return created zone name_servers."
 }

modules/zone/variables.tf

@@ -0,0 +1,5 @@
+# variables
+variable "name" {
+  type        = string
+  description = "Route53 Zone name"
+}

outputs.tf

@@ -2,3 +2,8 @@ output "zone_id" {
   value       = module.zone_and_records.zone_id
   description = "zone id"
 }
+
+output "ns_delegation_set" {
+  value       = [for item in module.zone_and_records.name_servers : "${item}."]
+  description = "The NS records list for zone to use as delegation set"
+}

tests/alb_record/0-setup.tf

@@ -1,9 +1,5 @@
 terraform {
   required_providers {
-    test = {
-      source = "terraform.io/builtin/test"
-    }
-
     aws = {
       source  = "hashicorp/aws"
       version = ">= 3.41"

tests/alb_record/README.md

@@ -13,7 +13,6 @@
 | Name | Version |
 |------|---------|
 | <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.41 |
-| <a name="provider_test"></a> [test](#provider\_test) | n/a |
 
 ## Modules
 
@@ -28,7 +27,6 @@
 | [aws_default_subnet.default_az_a](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/default_subnet) | resource |
 | [aws_default_subnet.default_az_b](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/default_subnet) | resource |
 | [aws_lb.test](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb) | resource |
-| test_assertions.dummy | resource |
 
 ## Inputs
 

tests/basic/0-setup.tf

@@ -1,9 +1,5 @@
 terraform {
   required_providers {
-    test = {
-      source = "terraform.io/builtin/test"
-    }
-
     aws = {
       source  = "hashicorp/aws"
       version = ">= 3.41"

tests/basic/README.md

@@ -10,9 +10,7 @@
 
 ## Providers
 
-| Name | Version |
-|------|---------|
-| <a name="provider_test"></a> [test](#provider\_test) | n/a |
+No providers.
 
 ## Modules
 
@@ -22,9 +20,7 @@
 
 ## Resources
 
-| Name | Type |
-|------|------|
-| test_assertions.dummy | resource |
+No resources.
 
 ## Inputs
 

tests/create-zone/0-setup.tf

@@ -0,0 +1,20 @@
+terraform {
+  required_providers {
+    aws = {
+      source  = "hashicorp/aws"
+      version = ">= 3.41"
+    }
+  }
+
+  required_version = ">= 1.3.0"
+}
+
+/**
+ * set the following env vars so that aws provider will get authenticated before apply:
+
+ export AWS_ACCESS_KEY_ID=xxxxxxxxxxxxxxxxxxxxxxxx
+ export AWS_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxx
+*/
+provider "aws" {
+  region = "eu-central-1"
+}

tests/create-zone/1-example.tf

@@ -0,0 +1,6 @@
+module "this" {
+  source = "../../"
+
+  zone        = "test-zone-creation.dasmeta.com"
+  create_zone = true
+}

tests/create-zone/README.md

@@ -0,0 +1,32 @@
+# basic
+
+<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
+## Requirements
+
+| Name | Version |
+|------|---------|
+| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
+| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.41 |
+
+## Providers
+
+No providers.
+
+## Modules
+
+| Name | Source | Version |
+|------|--------|---------|
+| <a name="module_this"></a> [this](#module\_this) | ../../ | n/a |
+
+## Resources
+
+No resources.
+
+## Inputs
+
+No inputs.
+
+## Outputs
+
+No outputs.
+<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->