Reset the max-examples default back to 100 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests run fast enough now that there's no need to lower this to 20. See the discussion at data-apis#246.
Merged
|
Could we just change our own workflow to have |
|
JAX is the exception, not us. If JAX is slower than most libraries, they should manually lower their max examples. Library defaults should match the common case, not the least common denominator. |
Previously it was log(max_examples), but this makes it very difficult to actually run a lot of examples by increasing max_examples.
|
I also changed the unvectorized max examples to scale linearly with max-examples instead of logarithmically. Otherwise, it's very difficult to actually run a lot of examples for unvectorized tests. We can adjust the scaling factor if 1/10 is not small enough by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests run fast enough now that there's no need to lower this to 20.
See the discussion at #246.