Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_sum to be more numerically correct #290

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Fix test_sum to be more numerically correct #290

merged 3 commits into from
Oct 2, 2024

Commits on Aug 8, 2024

  1. Split out assert_scalar_equals and assert_scalar_isclose

    @asmeurer
    asmeurer committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    aefe195 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Pass arguments through properly

    @asmeurer
    asmeurer committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8f240f6 View commit details
    Browse the repository at this point in the history

  2. Use condition numbers to filter out ill-conditioned value testing for… 

    … sum/cumulative_sum/prod

This isn't completely rigorous (I haven't tweaked the tolerances used in
isclose from the generous ones we were using before), but I haven't gotten
hypothesis to find any bad corner cases for this yet. If any crop up we can
easily tweak the values.

Fixes data-apis#168
    @asmeurer
    asmeurer committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    621316b View commit details
    Browse the repository at this point in the history