Added additional dependencies #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dli357
reviewed
Feb 16, 2023
| @@ -260,6 +263,21 @@ | |||
| </exclusion> | |||
| </exclusions> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Can we use dependencyManagement to overwrite transitive dependency versions? Then we can also remove the manual exclusions we did as part of the vulnerability fixes
There was a problem hiding this comment.
In this case, the dependences versions were missing from the JAR due to previous exclusions.
There was a problem hiding this comment.
Right, in that case dependencyManagement can allow us to overwrite those transitive dependencies without having to manually include them, i.e. we can remove the exclusions added in #141.
There was a problem hiding this comment.
See cdapio/hydrator-plugins#1747 for an example.
fernst
force-pushed
the
add-missing-dependencies
branch
from
ff46f71
to
fb482e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.