Update all RuntimeException

data-integrations · Jan 15, 2025 · 03bb629 · 03bb629
1 parent 37e4158
commit 03bb629
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/src/main/java/io/cdap/plugin/gcp/gcs/StorageClient.java b/src/main/java/io/cdap/plugin/gcp/gcs/StorageClient.java
@@ -32,6 +32,7 @@
 import io.cdap.cdap.api.exception.ErrorType;
 import io.cdap.cdap.api.exception.ErrorUtils;
 import io.cdap.plugin.gcp.common.GCPConnectorConfig;
+import io.cdap.plugin.gcp.common.GCPErrorDetailsProviderUtil;
 import io.cdap.plugin.gcp.common.GCPUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -135,9 +136,11 @@ public void createBucketIfNotExists(GCSPath path, @Nullable String location, @Nu
         LOG.warn("Getting 409 Conflict: {} Bucket at destination path {} may already exist.",
                  e.getMessage(), path.getUri());
       } else {
-        throw new RuntimeException(
+        String errorReason =
           String.format("Unable to create bucket %s. Ensure you entered the correct bucket path and " +
-                          "have permissions for it.", path.getBucket()), e);
+            "have permissions for it.", path.getBucket());
+        throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason,
+          GCPUtils.GCS_SUPPORTED_DOC_URL);
       }
     }
   }
@@ -220,9 +223,10 @@ private void pairTraverse(GCSPath sourcePath, GCSPath destPath, boolean recursiv
       sourceBucket = storage.get(sourcePath.getBucket());
     } catch (StorageException e) {
       // Add more descriptive error message
-      throw new RuntimeException(
-        String.format("Unable to access source bucket %s. ", sourcePath.getBucket())
-          + "Ensure you entered the correct bucket path.", e);
+      String errorReason = String.format("Unable to access destination bucket %s. ", destPath.getBucket()) +
+        "Ensure you entered the correct bucket path.";
+      throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason,
+        GCPUtils.GCS_SUPPORTED_DOC_URL);
     }
     if (sourceBucket == null) {
       String errorReason = String.format("Source bucket '%s' does not exist.", sourcePath.getBucket());
@@ -234,9 +238,10 @@ private void pairTraverse(GCSPath sourcePath, GCSPath destPath, boolean recursiv
       destBucket = storage.get(destPath.getBucket());
     } catch (StorageException e) {
       // Add more descriptive error message
-      throw new RuntimeException(
-        String.format("Unable to access destination bucket %s. ", destPath.getBucket())
-          + "Ensure you entered the correct bucket path.", e);
+      String errorReason = String.format("Unable to access destination bucket %s. ", destPath.getBucket()) +
+        "Ensure you entered the correct bucket path.";
+      throw GCPErrorDetailsProviderUtil.getHttpResponseExceptionDetailsFromChain(e, errorReason,
+        GCPUtils.GCS_SUPPORTED_DOC_URL);
     }
     if (destBucket == null) {
       String errorReason =