🐹 all: use github.com/database64128/netx-go to reduce linkname usage

go.mod

@@ -3,3 +3,5 @@ module github.com/database64128/tfo-go/v2
 go 1.21.0
 
 require golang.org/x/sys v0.24.1-0.20240828075529-ed67b1566aaf
+
+require github.com/database64128/netx-go v0.0.0-20240904075656-1efc34d35e1a

go.sum

@@ -1,2 +1,4 @@
+github.com/database64128/netx-go v0.0.0-20240904075656-1efc34d35e1a h1:EFUgNuSxsGOE6zP49HlhhXx+w0SZs6ADuqVEMaKSFFU=
+github.com/database64128/netx-go v0.0.0-20240904075656-1efc34d35e1a/go.mod h1:uMBPfZT3hyBlp6X8qIToro7wX+zymQTMe1bxfqUsbIs=
 golang.org/x/sys v0.24.1-0.20240828075529-ed67b1566aaf h1:q2Cx0keWwW5HecyZeIyA3DCuupo8A/zjDqsOQK0+Z80=
 golang.org/x/sys v0.24.1-0.20240828075529-ed67b1566aaf/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=

netpoll_windows_checklinkname0.go

@@ -5,13 +5,11 @@ package tfo
 import (
 	"net"
 	"sync"
-	"syscall"
 	"time"
 	_ "unsafe"
-)
 
-//go:linkname sockaddrToTCP net.sockaddrToTCP
-func sockaddrToTCP(sa syscall.Sockaddr) net.Addr
+	"golang.org/x/sys/windows"
+)
 
 //go:linkname execIO internal/poll.execIO
 func execIO(o *operation, submit func(o *operation) error) (int, error)
@@ -26,7 +24,7 @@ type pFD struct {
 	fdmuW uint32
 
 	// System file descriptor. Immutable until Close.
-	Sysfd syscall.Handle
+	Sysfd windows.Handle
 
 	// Read operation.
 	rop operation
@@ -65,10 +63,9 @@ type pFD struct {
 	kind byte
 }
 
-func (fd *pFD) ConnectEx(ra syscall.Sockaddr, b []byte) (n int, err error) {
-	fd.wop.sa = ra
+func (fd *pFD) ConnectEx(ra windows.Sockaddr, b []byte) (n int, err error) {
 	n, err = execIO(&fd.wop, func(o *operation) error {
-		return syscall.ConnectEx(o.fd.Sysfd, o.sa, &b[0], uint32(len(b)), &o.qty, &o.o)
+		return windows.ConnectEx(o.fd.Sysfd, ra, &b[0], uint32(len(b)), &o.qty, &o.o)
 	})
 	return
 }
@@ -89,7 +86,7 @@ type netFD struct {
 }
 
 //go:linkname newFD net.newFD
-func newFD(sysfd syscall.Handle, family, sotype int, net string) (*netFD, error)
+func newFD(sysfd windows.Handle, family, sotype int, net string) (*netFD, error)
 
 //go:linkname netFDInit net.(*netFD).init
 func netFDInit(fd *netFD) error

netpoll_windows_go121.go

@@ -3,8 +3,6 @@
 package tfo
 
 import (
-	"syscall"
-
 	"golang.org/x/sys/windows"
 )
 
@@ -14,7 +12,7 @@ import (
 type operation struct {
 	// Used by IOCP interface, it must be first field
 	// of the struct, as our code rely on it.
-	o syscall.Overlapped
+	o windows.Overlapped
 
 	// fields used by runtime.netpoll
 	runtimeCtx uintptr
@@ -24,12 +22,12 @@ type operation struct {
 
 	// fields used only by net package
 	fd     *pFD
-	buf    syscall.WSABuf
+	buf    windows.WSABuf
 	msg    windows.WSAMsg
-	sa     syscall.Sockaddr
-	rsa    *syscall.RawSockaddrAny
+	sa     windows.Sockaddr
+	rsa    *windows.RawSockaddrAny
 	rsan   int32
-	handle syscall.Handle
+	handle windows.Handle
 	flags  uint32
-	bufs   []syscall.WSABuf
+	bufs   []windows.WSABuf
 }

netpoll_windows_go123_checklinkname0.go

@@ -3,8 +3,6 @@
 package tfo
 
 import (
-	"syscall"
-
 	"golang.org/x/sys/windows"
 )
 
@@ -14,21 +12,21 @@ import (
 type operation struct {
 	// Used by IOCP interface, it must be first field
 	// of the struct, as our code rely on it.
-	o syscall.Overlapped
+	o windows.Overlapped
 
 	// fields used by runtime.netpoll
 	runtimeCtx uintptr
 	mode       int32
 
 	// fields used only by net package
 	fd     *pFD
-	buf    syscall.WSABuf
+	buf    windows.WSABuf
 	msg    windows.WSAMsg
-	sa     syscall.Sockaddr
-	rsa    *syscall.RawSockaddrAny
+	sa     windows.Sockaddr
+	rsa    *windows.RawSockaddrAny
 	rsan   int32
-	handle syscall.Handle
+	handle windows.Handle
 	flags  uint32
 	qty    uint32
-	bufs   []syscall.WSABuf
+	bufs   []windows.WSABuf
 }

tfo.go

@@ -13,9 +13,7 @@ import (
 	"context"
 	"errors"
 	"net"
-	"os"
 	"sync/atomic"
-	"syscall"
 	"time"
 )
 
@@ -228,15 +226,6 @@ func opAddr(a *net.TCPAddr) net.Addr {
 	return a
 }
 
-// wrapSyscallError takes an error and a syscall name. If the error is
-// a syscall.Errno, it wraps it in a os.SyscallError using the syscall name.
-func wrapSyscallError(name string, err error) error {
-	if _, ok := err.(syscall.Errno); ok {
-		err = os.NewSyscallError(name, err)
-	}
-	return err
-}
-
 // aLongTimeAgo is a non-zero time, far in the past, used for immediate deadlines.
 var aLongTimeAgo = time.Unix(0, 0)
 

tfo_bsd+linux.go

@@ -9,6 +9,7 @@ import (
 	"os"
 	"syscall"
 
+	"github.com/database64128/netx-go"
 	"golang.org/x/sys/unix"
 )
 
@@ -34,19 +35,7 @@ func ctrlNetwork(network string, family int) string {
 }
 
 func (d *Dialer) dialSingle(ctx context.Context, network string, laddr, raddr *net.TCPAddr, b []byte, ctrlCtxFn func(context.Context, string, string, syscall.RawConn) error) (*net.TCPConn, error) {
-	ltsa := (*tcpSockaddr)(laddr)
-	rtsa := (*tcpSockaddr)(raddr)
-	family, ipv6only := favoriteAddrFamily(network, ltsa, rtsa, "dial")
-
-	lsa, err := ltsa.sockaddr(family)
-	if err != nil {
-		return nil, err
-	}
-
-	rsa, err := rtsa.sockaddr(family)
-	if err != nil {
-		return nil, err
-	}
+	family, ipv6only := favoriteDialAddrFamily(network, laddr, raddr)
 
 	fd, err := d.socket(family)
 	if err != nil {
@@ -55,18 +44,18 @@ func (d *Dialer) dialSingle(ctx context.Context, network string, laddr, raddr *n
 
 	if err = d.setIPv6Only(fd, family, ipv6only); err != nil {
 		unix.Close(fd)
-		return nil, wrapSyscallError("setsockopt(IPV6_V6ONLY)", err)
+		return nil, os.NewSyscallError("setsockopt(IPV6_V6ONLY)", err)
 	}
 
 	if err = setNoDelay(fd, 1); err != nil {
 		unix.Close(fd)
-		return nil, wrapSyscallError("setsockopt(TCP_NODELAY)", err)
+		return nil, os.NewSyscallError("setsockopt(TCP_NODELAY)", err)
 	}
 
 	if err = setTFODialerFromSocket(uintptr(fd)); err != nil {
 		if !d.Fallback || !errors.Is(err, errors.ErrUnsupported) {
 			unix.Close(fd)
-			return nil, wrapSyscallError("setsockopt("+setTFODialerFromSocketSockoptName+")", err)
+			return nil, os.NewSyscallError("setsockopt("+setTFODialerFromSocketSockoptName+")", err)
 		}
 		runtimeDialTFOSupport.storeNone()
 	}
@@ -87,7 +76,7 @@ func (d *Dialer) dialSingle(ctx context.Context, network string, laddr, raddr *n
 
 	if laddr != nil {
 		if cErr := rawConn.Control(func(fd uintptr) {
-			err = syscall.Bind(int(fd), lsa)
+			err = unix.Bind(int(fd), unixSockaddrFromTCPAddr(laddr))
 		}); cErr != nil {
 			return nil, cErr
 		}
@@ -96,18 +85,13 @@ func (d *Dialer) dialSingle(ctx context.Context, network string, laddr, raddr *n
 		}
 	}
 
-	rusa, err := unixSockaddrFromSyscallSockaddr(rsa)
-	if err != nil {
-		return nil, err
-	}
-
 	var (
 		n           int
 		canFallback bool
 	)
 
 	if err = connWriteFunc(ctx, f, func(f *os.File) (err error) {
-		n, canFallback, err = connect(rawConn, rusa, b)
+		n, canFallback, err = connect(rawConn, unixSockaddrFromTCPAddr(raddr), b)
 		return err
 	}); err != nil {
 		if d.Fallback && canFallback {
@@ -132,24 +116,21 @@ func (d *Dialer) dialSingle(ctx context.Context, network string, laddr, raddr *n
 	return c.(*net.TCPConn), err
 }
 
-func unixSockaddrFromSyscallSockaddr(sa syscall.Sockaddr) (unix.Sockaddr, error) {
-	if sa == nil {
-		return nil, nil
+func unixSockaddrFromTCPAddr(a *net.TCPAddr) unix.Sockaddr {
+	if a == nil {
+		return nil
 	}
-	switch sa := sa.(type) {
-	case *syscall.SockaddrInet4:
+	if ip4 := a.IP.To4(); ip4 != nil {
 		return &unix.SockaddrInet4{
-			Port: sa.Port,
-			Addr: sa.Addr,
-		}, nil
-	case *syscall.SockaddrInet6:
-		return &unix.SockaddrInet6{
-			Port:   sa.Port,
-			ZoneId: sa.ZoneId,
-			Addr:   sa.Addr,
-		}, nil
-	}
-	return nil, errors.New("unsupported sockaddr type")
+			Port: a.Port,
+			Addr: [4]byte(ip4),
+		}
+	}
+	return &unix.SockaddrInet6{
+		Port:   a.Port,
+		ZoneId: uint32(netx.ZoneCache.Index(a.Zone)),
+		Addr:   [16]byte(a.IP),
+	}
 }
 
 func connect(rawConn syscall.RawConn, rsa unix.Sockaddr, b []byte) (n int, canFallback bool, err error) {
@@ -187,7 +168,7 @@ func connect(rawConn syscall.RawConn, rsa unix.Sockaddr, b []byte) (n int, canFa
 func getSocketError(fd int, call string) error {
 	nerr, err := unix.GetsockoptInt(fd, unix.SOL_SOCKET, unix.SO_ERROR)
 	if err != nil {
-		return wrapSyscallError("getsockopt", err)
+		return os.NewSyscallError("getsockopt", err)
 	}
 	if nerr != 0 {
 		return os.NewSyscallError(call, syscall.Errno(nerr))

tfo_connect_generic.go

@@ -26,84 +26,34 @@ func boolint(b bool) int {
 	return 0
 }
 
-// A sockaddr represents a TCP, UDP, IP or Unix network endpoint
-// address that can be converted into a syscall.Sockaddr.
-//
-// Copied from src/net/sockaddr_posix.go
-type sockaddr interface {
-	net.Addr
-
-	// family returns the platform-dependent address family
-	// identifier.
-	family() int
-
-	// isWildcard reports whether the address is a wildcard
-	// address.
-	isWildcard() bool
-
-	// sockaddr returns the address converted into a syscall
-	// sockaddr type that implements syscall.Sockaddr
-	// interface. It returns a nil interface when the address is
-	// nil.
-	sockaddr(family int) (syscall.Sockaddr, error)
-
-	// toLocal maps the zero address to a local system address (127.0.0.1 or ::1)
-	toLocal(net string) sockaddr
-}
-
-type tcpSockaddr net.TCPAddr
-
-func (a *tcpSockaddr) Network() string {
-	return "tcp"
-}
-
-func (a *tcpSockaddr) String() string {
-	return (*net.TCPAddr)(a).String()
-}
-
-// Copied from src/net/tcpsock_posix.go
-func (a *tcpSockaddr) family() int {
-	if a == nil || len(a.IP) <= net.IPv4len {
-		return syscall.AF_INET
-	}
-	if a.IP.To4() != nil {
-		return syscall.AF_INET
+// wrapSyscallError takes an error and a syscall name. If the error is
+// a syscall.Errno, it wraps it in a os.SyscallError using the syscall name.
+func wrapSyscallError(name string, err error) error {
+	if _, ok := err.(syscall.Errno); ok {
+		err = os.NewSyscallError(name, err)
 	}
-	return syscall.AF_INET6
+	return err
 }
 
-// Copied from src/net/tcpsock_posix.go
-func (a *tcpSockaddr) isWildcard() bool {
-	if a == nil || a.IP == nil {
-		return true
+// Modified from favoriteAddrFamily in src/net/ipsock_posix.go
+func favoriteDialAddrFamily(network string, laddr, raddr *net.TCPAddr) (family int, ipv6only bool) {
+	switch network {
+	case "tcp4":
+		return syscall.AF_INET, false
+	case "tcp6":
+		return syscall.AF_INET6, true
 	}
-	return a.IP.IsUnspecified()
-}
 
-//go:linkname ipToSockaddr net.ipToSockaddr
-func ipToSockaddr(family int, ip net.IP, port int, zone string) (syscall.Sockaddr, error)
-
-// Copied from src/net/tcpsock_posix.go
-func (a *tcpSockaddr) sockaddr(family int) (syscall.Sockaddr, error) {
-	if a == nil {
-		return nil, nil
+	if tcpAddrIs4(laddr) || tcpAddrIs4(raddr) {
+		return syscall.AF_INET, false
 	}
-	return ipToSockaddr(family, a.IP, a.Port, a.Zone)
+	return syscall.AF_INET6, false
 }
 
-//go:linkname loopbackIP net.loopbackIP
-func loopbackIP(net string) net.IP
-
-// Modified from src/net/tcpsock_posix.go
-func (a *tcpSockaddr) toLocal(net string) sockaddr {
-	la := *a
-	la.IP = loopbackIP(net)
-	return &la
+func tcpAddrIs4(a *net.TCPAddr) bool {
+	return a != nil && a.IP.To4() != nil
 }
 
-//go:linkname favoriteAddrFamily net.favoriteAddrFamily
-func favoriteAddrFamily(network string, laddr, raddr sockaddr, mode string) (family int, ipv6only bool)
-
 func (d *Dialer) dialTFOFromSocket(ctx context.Context, network, address string, b []byte) (*net.TCPConn, error) {
 	if ctx == nil {
 		panic("nil context")