Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In minimal use case, add_pypiper_args fails when composed with logmuse.add_logging_options #192

Open
vreuter opened this issue Jul 7, 2023 · 1 comment

Comments

@vreuter
Copy link
Member

vreuter commented Jul 7, 2023

I ran into a duplicate option name error when creating a pipeline using both logmuse and pypiper; namely, when composing logmuse.add_logging_options with pypiper.add_pypiper_args, e.g.

parser = argparse.ArgumentParser(...)
...
...
parser = pypiper.add_pypiper_args(logmuse.add_logging_options(parser))

It looks like this is because of inclusion of values from logmuse.LOGGING_CLI_OPTDATA in the "pypiper" group. I see the value for that, but it feels like unexpected behavior, and there's no message to that effect to the user. Maybe if the duplicated option name is one of the ones that pypiper knows is coming from logmuse by virtue of the import, it could suggest this (previous addition of logmuse options from a separate call to logmuse.add_logging_options) as a potential cause.

@vreuter
Copy link
Member Author

vreuter commented Jul 7, 2023

Tagged as "bug" though acknowledging that's debatable 😅

@vreuter vreuter changed the title In minimal use case, add_pypiper_args fails when composed with logmused.add_logging_options In minimal use case, add_pypiper_args fails when composed with logmuse.add_logging_options Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant