[PECO-1020] Adding mock constructor method for WorkspaceClient to support mocked ApiClient #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port mocked ApiClient
|
Thanks for contributing this! Note that WorkspaceClient.java is a generated file. You need to make this change in .codegen/workspace.java.tmpl as well, otherwise this change will be erased the next time we update the SDK. |
Done, Thanks for pointing out. |
mgyucht
approved these changes
Aug 30, 2023
auto-merge was automatically disabled
August 30, 2023 13:00
Head branch was pushed to by a user without write access
Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
gopalldb
force-pushed
the
sdk
branch
2 times, most recently
from
1ce88d5
to
b315cc8
Compare
|
jenkins merge |
pietern
added a commit
that referenced
this pull request
Sep 4, 2023
* Adding mock constructor method for WorkspaceClient to support mocked ApiClient ([#144](#144)). API Changes: * Renamed permissions APIs to no longer include the service name, for example: * `getJobPermissionLevels` -> `getPermissionLevels` * `getJobPermissions` -> `getPermissions` * `setJobPermissions` -> `setPermissions` * `updateJobPermissions` -> `updatePermissions` * Changed `create()` method for `workspaceClient.volumes()` service with new required argument order. * Added `supportsElasticDisk` field for `com.databricks.sdk.service.compute.NodeType`. * Changed `create()` method for `workspaceClient.dashboards()` service with new required argument order. * Added `workspaceClient.dashboardWidgets()` service. * Added `workspaceClient.queryVisualizations()` service. * Changed `name` field for `com.databricks.sdk.service.sql.CreateDashboardRequest` to be required. * Added `dashboardFiltersEnabled` field for `com.databricks.sdk.service.sql.CreateDashboardRequest`. * Added `runAsRole` field for `com.databricks.sdk.service.sql.CreateDashboardRequest`. * Added `runAsRole` field for `com.databricks.sdk.service.sql.Query`. * Added `runAsRole` field for `com.databricks.sdk.service.sql.QueryPostContent`. * Removed `dashboardId` field for `com.databricks.sdk.service.sql.WidgetOptions`. * Changed `position` field for `com.databricks.sdk.service.sql.WidgetOptions` to `com.databricks.sdk.service.sql.WidgetPosition` class. * Removed `text` field for `com.databricks.sdk.service.sql.WidgetOptions`. * Added `description` field for `com.databricks.sdk.service.sql.WidgetOptions`. * Added `title` field for `com.databricks.sdk.service.sql.WidgetOptions`. * Added `com.databricks.sdk.service.sql.CreateQueryVisualizationRequest` class. * Added `com.databricks.sdk.service.sql.CreateWidget` class. * Added `com.databricks.sdk.service.sql.DeleteDashboardWidgetRequest` class. * Added `com.databricks.sdk.service.sql.DeleteQueryVisualizationRequest` class. * Added `com.databricks.sdk.service.sql.RunAsRole` class. * Added `com.databricks.sdk.service.sql.WidgetPosition` class. OpenAPI SHA: 09a7fa63d9ae243e5407941f200960ca14d48b07, Date: 2023-09-04
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Adding mock constructor method for WorkspaceClient to support mocked ApiClient ([#144](#144)). API Changes: * Renamed permissions APIs to no longer include the service name, for example: * `getJobPermissionLevels` -> `getPermissionLevels` * `getJobPermissions` -> `getPermissions` * `setJobPermissions` -> `setPermissions` * `updateJobPermissions` -> `updatePermissions` * Changed `create()` method for `workspaceClient.volumes()` service with new required argument order. * Added `supportsElasticDisk` field for `com.databricks.sdk.service.compute.NodeType`. * Changed `create()` method for `workspaceClient.dashboards()` service with new required argument order. * Added `workspaceClient.dashboardWidgets()` service. * Added `workspaceClient.queryVisualizations()` service. * Changed `name` field for `com.databricks.sdk.service.sql.CreateDashboardRequest` to be required. * Added `dashboardFiltersEnabled` field for `com.databricks.sdk.service.sql.CreateDashboardRequest`. * Added `runAsRole` field for `com.databricks.sdk.service.sql.CreateDashboardRequest`. * Added `runAsRole` field for `com.databricks.sdk.service.sql.Query`. * Added `runAsRole` field for `com.databricks.sdk.service.sql.QueryPostContent`. * Removed `dashboardId` field for `com.databricks.sdk.service.sql.WidgetOptions`. * Changed `position` field for `com.databricks.sdk.service.sql.WidgetOptions` to `com.databricks.sdk.service.sql.WidgetPosition` class. * Removed `text` field for `com.databricks.sdk.service.sql.WidgetOptions`. * Added `description` field for `com.databricks.sdk.service.sql.WidgetOptions`. * Added `title` field for `com.databricks.sdk.service.sql.WidgetOptions`. * Added `com.databricks.sdk.service.sql.CreateQueryVisualizationRequest` class. * Added `com.databricks.sdk.service.sql.CreateWidget` class. * Added `com.databricks.sdk.service.sql.DeleteDashboardWidgetRequest` class. * Added `com.databricks.sdk.service.sql.DeleteQueryVisualizationRequest` class. * Added `com.databricks.sdk.service.sql.RunAsRole` class. * Added `com.databricks.sdk.service.sql.WidgetPosition` class. OpenAPI SHA: 09a7fa63d9ae243e5407941f200960ca14d48b07, Date: 2023-09-04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional constructor in WorkspaceClient to support mocking ApiClient
Changes
A new constructor in WorkspaceClient to support mocking ApiClient
Tests
Ran $mvn clean package to verify all test cases and compilation errors