Update OpenAPI spec #160
Merged
Update OpenAPI spec #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
approved these changes
Oct 2, 2023
| {{- define "type-unboxed" -}} | ||
| {{- if .IsBool}}boolean | ||
| {{- else if .IsInt64}}long | ||
| {{- else if .IsFloat64}}double |
| {{ else }} | ||
| Any types that have no fields (i.e. primitives or array types) or are not enums are not represented by distinct Java | ||
| types in the Java SDK. | ||
| {{skipThisFile}} |
There was a problem hiding this comment.
This would prevent generation of WorkspaceId.java and other files right?
There was a problem hiding this comment.
Correct. That's why several files disappear from the .gitattributes file.
.codegen.json
Outdated
| @@ -19,6 +22,7 @@ | |||
| }, | |||
| "toolchain": { | |||
| "require": ["mvn", "java"], | |||
| "setup": ["rm -rf databricks-sdk-java/src/main/java/com/databricks/sdk/service"], | |||
There was a problem hiding this comment.
What is this for? Do we want to use the force flag?
There was a problem hiding this comment.
True, we can just use -r.
| * string of utf-8 characters. The value can be an empty string, with maximum length of 255 | ||
| * characters. The key can be of maximum length of 127 characters, and cannot be empty. | ||
| */ | ||
| // type CustomTags Map<String,String> |
There was a problem hiding this comment.
Since these were never used, this change shouldn't be breaking right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update of the OpenAPI spec. This also introduces the template_libraries field being added in databricks/databricks-sdk-go#635.
This PR contains some other changes:
float/Floattodouble/Double. OpenAPI specs currently specifyformat: "double"for all non-integral numeric values.Tests
Added AccountMetastoreAssignmentsIT to verify the correct functionality of the updated AccountMetastoreAssignments API.
Nightly tests passed on this PR.