Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DBFSPath as os.PathLike implementation #131

Merged
merged 18 commits into from
Jul 16, 2024
Merged

Added DBFSPath as os.PathLike implementation #131

merged 18 commits into from
Jul 16, 2024

Commits on Jul 15, 2024

  1. Factor out WorkspacePath code that doesn't interact directly with the… 

    … WorkspaceAPI.

In addition, type-hint the APIs as much as possible.
    @asnare
    asnare committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ceb137d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/dbfspath

    @asnare
    asnare committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2a82a9e View commit details
    Browse the repository at this point in the history

  3. Rename type alias: DBPath -> P

    @asnare
    asnare committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    abf0f48 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/dbfspath

    @asnare
    asnare committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a88101e View commit details
    Browse the repository at this point in the history

  5. More type hints.

    @asnare
    asnare committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    0e7fe76 View commit details
    Browse the repository at this point in the history

  6. Mark .as_fuse() as something that all subclasses should implement.

    @asnare
    asnare committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6d42c94 View commit details
    Browse the repository at this point in the history

  7. Initial implementation of DBFSPath. 

    Refactoring still required.
    @asnare
    asnare committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5fd88dc View commit details
    Browse the repository at this point in the history

  8. Update the integration tests to also cover DBFSPath.

    @asnare
    asnare committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    dc48f3c View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Formatting.

    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9423c6c View commit details
    Browse the repository at this point in the history

  2. Cache object information when checking if a file exists.

    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2e9a3ec View commit details
    Browse the repository at this point in the history

  3. Avoid allow_missing handling unless deleting the target fails. 

    For DBFS it doesn't fail if missing so we need to check before trying.
    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a15eca5 View commit details
    Browse the repository at this point in the history

  4. Refactor rename()/replace(). 

    There's no common implementation, and DBFS needs to treat them differently anyway.
    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f5bb6b9 View commit details
    Browse the repository at this point in the history

  5. Move the abstract methods to a single location.

    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    29913b0 View commit details
    Browse the repository at this point in the history

  6. The implementation of .expanduser() is the same for both implementati… 

    …ons.
    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1156dae View commit details
    Browse the repository at this point in the history

  7. Default to not supporting .as_uri().

    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    59be839 View commit details
    Browse the repository at this point in the history

  8. Factor out mkdir() argument validation.

    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a68776f View commit details
    Browse the repository at this point in the history

  9. Integration tests for .rename() and .replace() and block unsupported … 

    …operations.
    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0fd3050 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary pylint overrides. 

    These overrides aren't needed with python 3.10, the only version we currently lint against.
    @asnare
    asnare committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b84b159 View commit details
    Browse the repository at this point in the history