Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SparkR library load #436

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

a0x8o
Copy link
Contributor

@a0x8o a0x8o commented Oct 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #436 (e4fe62a) into main (19f2e9f) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   95.01%   95.02%   +0.01%     
==========================================
  Files         198      198              
  Lines        5658     5692      +34     
  Branches      178      175       -3     
==========================================
+ Hits         5376     5409      +33     
- Misses        282      283       +1     
Files Coverage Δ
...abricks/labs/mosaic/core/index/H3IndexSystem.scala 97.59% <97.50%> (-0.37%) ⬇️

@@ -11,5 +11,4 @@ API Documentation
spatial-functions
spatial-indexing
spatial-predicates
spatial-aggregations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a0x8o why are these pages removed from docs?

@@ -2,495 +2,391 @@
"cells": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a0x8o has this changed so substantially by intention?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a0x8o I cant visualise changes here, is this an intentional change?
The diff is 10K lines

@@ -5,7 +5,6 @@ Usage
:maxdepth: 2

installation
install-gdal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a0x8o why is this docs page removed?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants