CI/CD overhaul #403
Merged
CI/CD overhaul #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was identical test cases to resample_tests
tnixon
requested changes
Jul 10, 2024
tnixon
approved these changes
Jul 11, 2024
R7L208
approved these changes
Jul 11, 2024
| url: https://help.databricks.com/ | ||
| about: Issues related to Databricks and not related to UCX | ||
|
|
||
| - name: UCX Documentation |
There was a problem hiding this comment.
Suggested change
| - name: UCX Documentation | |
| - name: Tempo Documentation |
| contact_links: | ||
| - name: General Databricks questions | ||
| url: https://help.databricks.com/ | ||
| about: Issues related to Databricks and not related to UCX |
There was a problem hiding this comment.
Suggested change
| about: Issues related to Databricks and not related to UCX | |
| about: Issues related to Databricks and not related to Tempo |
python/install_cmd.txt
Outdated
There was a problem hiding this comment.
I think this got accidentally checked in while I was working. @jtisbell4 - did you add this one?
python/requirements/dbr113.txt
Outdated
There was a problem hiding this comment.
Can you allow minor releases on the requirement files so we are able to automatically pick up patches that have bug and security fixes?
python/tests/tsdf_tests.py
Outdated
| def test_tsdf_interpolate(self): | ||
| ... | ||
| def test_tsdf_interpolate(self): ... |
There was a problem hiding this comment.
Can we remove this test since it's not implemented?
| "my_table_optimization_col_fails zorder by (symbol,date,event_time)\n^^^\n" | ||
| ], | ||
| ) | ||
| if pkg_version.parse(DELTA_VERSION) < pkg_version.parse("2.0.0"): |
There was a problem hiding this comment.
@jtisbell4 - can we mock this env var so there's no conditional logic in the test? the if/else will make it conditionally fail/pass but the test outcome should be consistent regardless of delta version installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes to test and build infrastructure, predominantly related to
tox:toxenvironments correctly configuredtoxpython/tests/requirementsSparkSessioninitialization dynamic in test class setupA few minor changes in
python/tempo:TSDF.withRangeStatsevent_timecolumn assumption and made Z-ORDER attempt contingent onoptimizationColsinio.write