Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarifying language about vertical vs horizontal resolution and the m… #459

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jonjab
Copy link
Contributor

@jonjab jonjab commented Nov 26, 2024

…etadata.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Closes #86

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

I clarified the difference between horiZontal units of the CRS and the vertical units of the data attributes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

Copy link

github-actions bot commented Nov 26, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-459

The following changes were observed in the rendered markdown documents:

 01-raster-structure.md                     | 14 ++++++++++----
 08-vector-plot-shapefiles-custom-legend.md |  4 ++--
 09-vector-when-data-dont-line-up-crs.md    |  2 +-
 instructor-notes.md                        | 31 +++++++++++++++---------------
 md5sum.txt                                 |  8 ++++----
 5 files changed, 33 insertions(+), 26 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-12-02 19:40:50 +0000

github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonjab I am not familiar enough with the specifics of working with geospatial data to have an opinion on whether your changes are accurate. But I can confirm that I found no typos, and the modifications seem reasonable and helpful to me.

Can you expand on your reasons for adjusting the estimated timings?

@@ -89,40 +89,40 @@ polygon edge not found
> {: .error}
> ```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went funky with this error message block when the lesson was converted to the Workbench. I will open a PR to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue in lesson one - units
2 participants