Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #131 fixed #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

issue #131 fixed #175

wants to merge 2 commits into from

Conversation

jeestr4d
Copy link
Collaborator

#131 Fixed

Added validation if CloudSec is enabled by checking the prescence of cloudsecPreSharedKey instances.

Local pytest result:

aci-preupgrade-validation-script.py 100% 189KB 294.9KB/s 00:00
jeestrad@JEESTRAD-M-L6VV ACI-Pre-Upgrade-Validation-Script % python3 -m pytest tests/cloudsec_encryption_check
==================================================================================== test session starts ====================================================================================
platform darwin -- Python 3.9.6, pytest-8.2.0, pluggy-1.5.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
collected 4 items

tests/cloudsec_encryption_check/test_cloudsec_encryption_check.py::test_logic[icurl_outputs0-5.2(6a)-N/A] PASSED [ 25%]
tests/cloudsec_encryption_check/test_cloudsec_encryption_check.py::test_logic[icurl_outputs1-5.2(6b)-N/A] PASSED [ 50%]
tests/cloudsec_encryption_check/test_cloudsec_encryption_check.py::test_logic[icurl_outputs2-6.0(6b)-PASS] PASSED [ 75%]
tests/cloudsec_encryption_check/test_cloudsec_encryption_check.py::test_logic[icurl_outputs3-6.0(6b)-FAIL - OUTAGE WARNING!!] PASSED [100%]

===================================================================================== warnings summary ======================================================================================
aci-preupgrade-validation-script.py:123
/Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script/ACI-Pre-Upgrade-Validation-Script/aci-preupgrade-validation-script.py:123: DeprecationWarning: invalid escape sequence \s
self.prompt = "#\s.$" #"[^#]#[ ](.)[ ]*$"

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=============================================================================== 4 passed, 1 warning in 0.02s ================================================================================

Test in lab fabric:

jeestrad@d-apic1:~> python /tmp/aci-preupgrade-validation-script.py

[Check 1/2] ClouSec Encrpytion Check... N/A
[Check 2/2] LLDP Custom Interface Description Defect... PASS

jeestrad@d-apic1:~> python /tmp/aci-preupgrade-validation-script.py

[Check 1/2] ClouSec Encrpytion Check... The CloudSec Encryption feature is deprecated in target version FAIL - OUTAGE WARNING!!
[Check 2/2] LLDP Custom Interface Description Defect... PASS

@jeestr4d jeestr4d requested a review from monrog2 October 10, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant