Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPA Air Data Modification for Automation #1073

Closed
wants to merge 2 commits into from

Conversation

saanikaaa
Copy link
Contributor

No description provided.

filename: The local filename to save the downloaded ZIP file.
"""

response = requests.get(url)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add try-catch block for this code.


response = requests.get(url)

if response.status_code == 200: # Check for successful response (200 OK)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add retry option if response.status_code is not 200

else:
logging.error(f'Error downloading file: {response.status_code}')


def request_and_write_csv(csv_file_path, filename):
response = requests.get(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add try catch block and retry option.

Copy link

@krishnaswamypradeep krishnaswamypradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work on the comments.

@saanikaaa saanikaaa closed this Sep 26, 2024
@saanikaaa saanikaaa deleted the epa_air_pr branch September 26, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants