US_BLS_Jolts data refresh #983
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaits
reviewed
Oct 10, 2024
ajaits
reviewed
Oct 10, 2024
ajaits
reviewed
Oct 10, 2024
ajaits
reviewed
Oct 10, 2024
ajaits
reviewed
Oct 14, 2024
scripts/us_bls/jolts/bls_jolts.py
Outdated
| jolts_df['Value'] = jolts_df['value'] | ||
|
|
||
| return jolts_df, schema_mapping | ||
|
|
||
|
|
||
| def remap_dcid(): |
There was a problem hiding this comment.
Pls add a block comment on what this function is doing.
Since it is only calling print(0 but not returning anything, is this just to print the mcf on console fro debugging or is the output redirected to a file?
ajaits
reviewed
Oct 14, 2024
scripts/us_bls/jolts/bls_jolts.py
Outdated
Comment on lines
249
to
251
| for f_key, f_value in mcf_config._mcf_map.items(): | ||
| if f_key in line: | ||
| if len(line) == len(f_key): |
There was a problem hiding this comment.
instead of a loop to check against each entry, can't we lookup the entry by key:
f_value = mcf_config._mcf_map.get(line)
if f_value:
line = f_value
ajaits
reviewed
Oct 14, 2024
scripts/us_bls/jolts/mcf_config.py
Outdated
| @@ -0,0 +1,674 @@ | |||
| _mcf_map = { | |||
There was a problem hiding this comment.
Since this is the same as map_config.py, can't we just have one of these dicts?
Having two identical dicts makes maintenance long term harder as these two will have to be kept in sync for edits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: If any new statistical variable comes in future , it must be added to the dictionaries :