-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evgenii/fix limit rewrite #100
Closed
ewgenius
wants to merge
49
commits into
datafusion-contrib:main
from
spiceai:evgenii/fix-limit-rewrite
Closed
evgenii/fix limit rewrite #100
ewgenius
wants to merge
49
commits into
datafusion-contrib:main
from
spiceai:evgenii/fix-limit-rewrite
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* testing * testing2 * Rewrite all table scans to use federated table name * Wrap the table scan in a subquery alias
* Rewrite subquery table scans to point to remote table * Add tracing * more tracing * more debug logging * Handle subquery in binary expressions
* Fix the table scan rewrite to properly rewrite column relations * Handle more expressions for table scan rewrites
Update Support for multiple table occurrences in single expression Support for multiple different tables in single aggregation expression Document rewrite_column_name_in_expr logic Update Fix spelling
…uery when executing (#10) * keep original qualified_field when wrap_projections * only mutate the table reference when sending plan to execute * formatting * rename method
* do not over eager rewrite column when col relation is there * add more tests * Update sources/sql/src/lib.rs Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
* Add List types parsing support to schema cast * Update to use arrow-json for lists parsing
* Add List types parsing support to schema cast * Update to use arrow-json for lists parsing * Add interval cast given original schema * Fix test --------- Co-authored-by: sgrebnov <sergei.grebnov@gmail.com> Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
* Add Structs parsing support to schema cast * Optimize memory space
* feat: Add AST analyzer middleware * fix: Remove redundant ast_analyzer call * chore: Variable does not need to be mutable
* optimize_recursively should check the provider for subqueries * Preserve the vec<provider>,use apply_subqueries * Federate subtree in subquery * clean up * Rewrite federation as optimizer rule * Revert "Rewrite federation as optimizer rule" This reverts commit e0ff999. * Keep federaion rule as analyzer rule, handle InSubquery federation * Wrap a Projection plan when the entire Insubquery can be federated * not run scalar_subquery_to_join and update scalar subquery handling * Resolve outref federation provider * clean up * Include table reference created by subquery aliases * Remove redundant clone * Do not panic on ScanResult unwrap
* Fix tests * fix * fix formatting errors * fix clippy * clean dependencies, remove outdated crates and test * update test to follow upstream fix: align to upstream changes and pass all tests# * remove commented out code * fix
…e name (#33) * Rewrite shouldn't be performed on a column name same as the table name * fix comment * Add unit test
…pport it (#29) * Don't rewrite table names inside subquery when engine doesn't support it * resolve merge conflicts * cleanup and update condition for detecting subquery * Add test & cleanup * fix: make clippy happy * Define subquery_use_partial_path as sqlexecutor trait
…ewrite_table_scans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display
for displaying federated plansFederatedPlanner
public for use in custom query planners (Added CI #14)optimize_projections
as part of federated plan optimization (fix: compilation error in test #24)optimize_projections
rule (feat: break out SQL Writer #25)