Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evgenii/fix limit rewrite #100

Closed

Conversation

ewgenius
Copy link
Contributor

@ewgenius ewgenius commented Jan 2, 2025

phillipleblanc and others added 30 commits May 9, 2024 14:56
* testing

* testing2

* Rewrite all table scans to use federated table name

* Wrap the table scan in a subquery alias
* Rewrite subquery table scans to point to remote table

* Add tracing

* more tracing

* more debug logging

* Handle subquery in binary expressions
* Fix the table scan rewrite to properly rewrite column relations

* Handle more expressions for table scan rewrites
Update

Support for multiple table occurrences in single expression

Support for multiple different tables in single aggregation expression

Document rewrite_column_name_in_expr logic

Update

Fix spelling
…uery when executing (#10)

* keep original qualified_field when wrap_projections

* only mutate the table reference when sending plan to execute

* formatting

* rename method
* do not over eager rewrite column when col relation is there

* add more tests

* Update sources/sql/src/lib.rs

Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>

---------

Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
phillipleblanc and others added 19 commits August 22, 2024 15:14
* Add List types parsing support to schema cast

* Update to use arrow-json for lists parsing
* Add List types parsing support to schema cast

* Update to use arrow-json for lists parsing

* Add interval cast given original schema

* Fix test

---------

Co-authored-by: sgrebnov <sergei.grebnov@gmail.com>
Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
* Add Structs parsing support to schema cast

* Optimize memory space
* feat: Add AST analyzer middleware

* fix: Remove redundant ast_analyzer call

* chore: Variable does not need to be mutable
* optimize_recursively should check the provider for subqueries

* Preserve the vec<provider>,use apply_subqueries

* Federate subtree in subquery

* clean up

* Rewrite federation as optimizer rule

* Revert "Rewrite federation as optimizer rule"

This reverts commit e0ff999.

* Keep federaion rule as analyzer rule, handle InSubquery federation

* Wrap a Projection plan when the entire Insubquery can be federated

* not run scalar_subquery_to_join and update scalar subquery handling

* Resolve outref federation provider

* clean up

* Include table reference created by subquery aliases

* Remove redundant clone

* Do not panic on ScanResult unwrap
* Fix tests

* fix

* fix formatting errors

* fix clippy

* clean dependencies, remove outdated crates and test

* update test to follow upstream

fix: align to upstream changes and pass all tests#

* remove commented out code

* fix
…e name (#33)

* Rewrite shouldn't be performed on a column name same as the table name

* fix comment

* Add unit test
…pport it (#29)

* Don't rewrite table names inside subquery when engine doesn't support it

* resolve merge conflicts

* cleanup and update condition for detecting subquery

* Add test & cleanup

* fix: make clippy happy

* Define subquery_use_partial_path as sqlexecutor trait
@ewgenius ewgenius closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants