Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: break out SQL Writer #25

Merged
merged 1 commit into from
Mar 8, 2024
Merged

feat: break out SQL Writer #25

merged 1 commit into from
Mar 8, 2024

Conversation

backkem
Copy link
Collaborator

@backkem backkem commented Mar 8, 2024

Initial refactor to break out the SQL serialization for apache/datafusion#8661, apache/datafusion#9495.

@backkem backkem requested a review from devinjdangelo March 8, 2024 10:55
Copy link
Collaborator

@devinjdangelo devinjdangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Excited to see how efforts to upstream this functionality progress.

sql-writer/examples/expr.rs Outdated Show resolved Hide resolved
@devinjdangelo devinjdangelo changed the title Break out SQL Writer feat: break out SQL Writer Mar 8, 2024
@backkem backkem merged commit 3545919 into main Mar 8, 2024
15 checks passed
@backkem backkem deleted the sql-writer branch March 8, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants