Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schema to ast builder #26

Closed
wants to merge 2 commits into from
Closed

feat: add schema to ast builder #26

wants to merge 2 commits into from

Conversation

sardination
Copy link
Contributor

SQL languages will typically have schemas, so add support for schema names to the table scan AST builder.

@sardination sardination changed the title add schema to ast builder feat: add schema to ast builder Mar 14, 2024
@backkem
Copy link
Collaborator

backkem commented Mar 15, 2024

Hi @sardination this makes sense indeed.

We recently started upstreaming the SQL serialization logic to the main DataFusion repo in apache/datafusion#9596. I've yet to come up with a strategy around how to deal with the transition phase in this repo.

In the meantime, let me know if you're interested in upstreaming this change as well or if you prefer I take care of that.

@sardination
Copy link
Contributor Author

Hi @sardination this makes sense indeed.

We recently started upstreaming the SQL serialization logic to the main DataFusion repo in apache/arrow-datafusion#9596. I've yet to come up with a strategy around how to deal with the transition phase in this repo.

In the meantime, let me know if you're interested in upstreaming this change as well or if you prefer I take care of that.

Awesome! I will go ahead and open an upstream PR for this.

@devinjdangelo
Copy link
Collaborator

I believe this was completed upstream, so closing the PR here!

@philippemnoel philippemnoel deleted the include-schema branch April 16, 2024 01:57
phillipleblanc pushed a commit that referenced this pull request Jan 10, 2025
* optimize_recursively should check the provider for subqueries

* Preserve the vec<provider>,use apply_subqueries

* Federate subtree in subquery

* clean up

* Rewrite federation as optimizer rule

* Revert "Rewrite federation as optimizer rule"

This reverts commit e0ff999.

* Keep federaion rule as analyzer rule, handle InSubquery federation

* Wrap a Projection plan when the entire Insubquery can be federated

* not run scalar_subquery_to_join and update scalar subquery handling

* Resolve outref federation provider

* clean up

* Include table reference created by subquery aliases

* Remove redundant clone

* Do not panic on ScanResult unwrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants